WINC-730: Add WICD unit test stub #1018
Conversation
sebsoto
changed the title
openshift-ci
bot
added
the
approved
|
/approve cancel |
openshift-ci
bot
removed
the
approved
sebsoto
force-pushed
the
wicdUnitMakeEndpoint
branch
from
9373703
to
c570de2
Compare
|
/lgtm Relates to openshift/release#27251 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: selansen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
hack/wicd-unit.sh
Outdated
|
|
||
| # Ensure the image used in the release job has ssh installed, as this will be used to remotely run tests against a | ||
| # Windows VM. Running a dummy command to ensure connection to the VM is possible | ||
| ssh -i $KUBE_SSH_KEY_PATH $INSTANCE_USERNAME@$INSTANCE_ADDRESS "dir" |
There was a problem hiding this comment.
Consider including -o StrictHostKeyChecking=no to disable strict host key checking.
| @@ -179,6 +179,10 @@ lint: | |||
| unit: | |||
There was a problem hiding this comment.
Include a reference in the PR message to the release PR that introduces the job.
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This commit adds a Make target for unit testing WICD. The purpose of this is to validate that the WICD unit release job is fufilling all of its requirements. Once both this stub and the release job are created, this stub can be expanded to actually perform the tests required of it.
sebsoto
force-pushed
the
wicdUnitMakeEndpoint
branch
from
c570de2
to
0b22ca1
Compare
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/hold to investigate CI failures. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test vsphere-e2e-operator |
|
/test platform-none-vsphere-e2e-operator |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@sebsoto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This commit adds a Make target for unit testing WICD. The purpose of
this is to validate that the WICD unit release job is fufilling all of
its requirements. Once both this stub and the release job are created,
this stub can be expanded to actually perform the tests required of it.