Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-5894: [wm_controller] Fix Machine node upgrades #1388

Merged
merged 1 commit into from Jan 19, 2023
Merged

[release-4.11] OCPBUGS-5894: [wm_controller] Fix Machine node upgrades #1388

merged 1 commit into from Jan 19, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1382

/assign saifshaikh48

@saifshaikh48
Fix Machine node upgrades
8d91787 
This commit fixes an issue where Machine node were not being identified as
out-of-date. This made them skip the deconfigure process, preventing draining
nodes, which would have resulted in a user workload disruptions during upgrade.

Fixes OCPBUGS-5732
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 16, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5803 has been cloned as Jira Issue OCPBUGS-5894. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-5894: [wm_controller] Fix Machine node upgrades

In response to this:

This is an automated cherry-pick of #1382

/assign saifshaikh48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] OCPBUGS-5803: [wm_controller] Fix Machine node upgrades [release-4.11] OCPBUGS-5894: [wm_controller] Fix Machine node upgrades Jan 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 16, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5894, which is invalid:

  • expected dependent Jira Issue OCPBUGS-5803 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1382

/assign saifshaikh48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-5894: [wm_controller] Fix Machine node upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sebsoto
Copy link
Contributor

sebsoto commented Jan 16, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
aravindhp
aravindhp approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtnbikenc
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 17, 2023
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Jira Issue OCPBUGS-5894, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5803 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-5803 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 17, 2023
@openshift-ci openshift-ci bot requested a review from rrasouli January 17, 2023 14:24
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 33d66af and 2 for PR HEAD 8d91787 in total

@saifshaikh48
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 877e2bb into openshift:release-4.11 Jan 19, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5894 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1382

/assign saifshaikh48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
@cp-paas-bot
Updated US source to: 877e2bb Merge pull request openshift#1388 from …
4576ba3 
…openshift-cherrypick-robot/cherry-pick-1382-to-release-4.11

Updated upstream source commit.
Commit details follow:

Signed-off-by: OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>
Project: https://github.com/openshift/windows-machine-config-operator.git
Branch:  release-4.11
Commit:  877e2bb
Author:  OpenShift Merge Robot
Date:    Thu, 19 Jan 2023 18:43:13 -0500

    Merge pull request openshift#1388 from openshift-cherrypick-robot/cherry-pick-1382-to-release-4.11

    [release-4.11] OCPBUGS-5894: [wm_controller] Fix Machine node upgrades

Additional included commit: 8d91787

Referenced RedHat JIRA issues: OCPBUGS-5732, OCPBUGS-5894

automerge: yes
x-md5: 73dd1c058b9b78194ab1165b09dac96f
Change-Id: I5066d41fad6f31e82ca41750387fafa8413f0a27
mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
Merge branch 'rhaos-4.11-rhel-8__upstream__73dd1c058b9b78194ab1165b09…
6a593a7 
…dac96f' into 'rhaos-4.11-rhel-8'

Updated US source to: 877e2bb Merge pull request openshift#1388 from openshift-cherrypick-robot/cherry-pick-1382-to-release-4.11

See merge request openshift-winc-midstream/openshift-winc-midstream!100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

@rrasouli rrasouli Awaiting requested review from rrasouli

Assignees

@aravindhp aravindhp

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @sebsoto @mtnbikenc @saifshaikh48 @aravindhp @openshift-merge-robot