Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-8037: Check for error when deleting directories #1437

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[release-4.12] OCPBUGS-8037: Check for error when deleting directories #1437

merged 1 commit into from
Feb 28, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1386

/assign mansikulkarni96

@sebsoto
Check for error when deleting dir
6326d2e 
Directory deletion is not being caught because err is nil, while
the actual reported error is present in out. This is being fixed by
using the PowerShell alternative, which will properly report an error.

In order to make use of Remove-Dir, trailing backslashes were removed
from constants, as they were causing unintentional escaping of quotes.

Fixes OCPBUGS-5887
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5887 has been cloned as Jira Issue OCPBUGS-8037. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-8037: Check for error when deleting directories

In response to this:

This is an automated cherry-pick of #1386

/assign mansikulkarni96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-5887: Check for error when deleting directories [release-4.12] OCPBUGS-8037: Check for error when deleting directories Feb 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 28, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8037, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5887 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-5887 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1386

/assign mansikulkarni96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from rrasouli February 28, 2023 15:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-8037: Check for error when deleting directories

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@sebsoto
Copy link
Contributor

sebsoto commented Feb 28, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@mansikulkarni96
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1ae9428 into openshift:release-4.12 Feb 28, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8037 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1386

/assign mansikulkarni96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrasouli rrasouli Awaiting requested review from rrasouli

@aravindhp aravindhp Awaiting requested review from aravindhp

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @mansikulkarni96 @sebsoto @openshift-merge-robot