New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-8055: [release-4.11] [build] Fix containerd version reporting #1439
OCPBUGS-8055: [release-4.11] [build] Fix containerd version reporting #1439
Conversation
@mansikulkarni96: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
/jira cherrypick OCPBUGS-7843 |
@mansikulkarni96: Jira Issue OCPBUGS-7843 has been cloned as Jira Issue OCPBUGS-8055. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mansikulkarni96: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mansikulkarni96: This pull request references Jira Issue OCPBUGS-8055, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
03c52b7
to
6818ffb
Compare
/jira refresh |
@mansikulkarni96: This pull request references Jira Issue OCPBUGS-8055, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Containerd Makefile uses VERSION env var to set the containerd version if it is not set. When we run the make command in WMCO Dockerfile, the VERSION var is already set to the golang image version of the base image eg: openshift/release:rhel-8-release-golang-1.19-openshift-4.12 This is the root cause of containerd Makefile not setting the version and we see containerd 1.19 as the misreported version in 4.12 and 1.18 in 4.11 cluster. One way to solve this issue is unsetting the env var in Dockerfile however it may have other unknown implications with versions. - Add a containerd hardcoded version variable in Makefile - Update hack/update_submodules.sh to pull upstream tags from Containerd submodule repository and generate a commit that updates the Makefile containerd version variable - Call containerd make endpoint in the Dockerfiles (Manually cherry picked from commit 7d41c8f)
This commit was generated using hack/update_submodules.sh (cherry picked from commit a3ca339)
6818ffb
to
2da90d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required cluster did not come up. |
/retest-required vsphere-e2e-operator failed to get log files which is a known flake and is being investigated. |
@mansikulkarni96: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mansikulkarni96: Jira Issue OCPBUGS-8055: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8055 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Containerd Makefile uses VERSION env var to set the containerd version if it is not already set. When we run the make command in WMCO Dockerfile, the VERSION var is already set to the golang image version of the base image eg: registry.ci.openshift.org/openshift/release:rhel-8-release-golang-1.19-openshift-4.12.
This is the root cause of containerd Makefile not setting the version and we see containerd 1.19 as the misreported version in 4.12 and 1.18 in 4.11 cluster.
One way to solve this issue is unsetting the env var in Dockerfile however it may have other unknown implications with versions. Adding a containerd Makefile target instead that will set the value of the ENV var within context.
(manually cherry-pick from #1424)