Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] WINC-983: [e2e] Ensure required log files are non-empty #1458

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[release-4.12] WINC-983: [e2e] Ensure required log files are non-empty #1458

merged 1 commit into from
Mar 6, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1421

/assign mansikulkarni96

@mansikulkarni96
Ensure required log files are non-empty
5c464ba 
This commit  adds a check to the logs tests to check that
log files have non-zero size, ensuring they are actually being
written to by the services.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2023
Merged
@openshift-ci openshift-ci bot requested review from aravindhp and sebsoto March 5, 2023 04:47
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2023
@mansikulkarni96
Copy link
Member

/retest-required

@mansikulkarni96
Copy link
Member

Tests failing on daemonset scale:

Received unexpected error:
        	            	timed out waiting for daemonset noop-ds to scale, current status: {CurrentNumberScheduled:1 NumberMisscheduled:0 DesiredNumberScheduled:1 NumberReady:1 ObservedGeneration:1 UpdatedNumberScheduled:1 NumberAvailable:1 NumberUnavailable:0 CollisionCount:<nil> Conditions:[]}

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@aravindhp
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3400c4d into openshift:release-4.12 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @mansikulkarni96 @aravindhp @openshift-merge-robot