Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] WINC-983: [e2e] Ensure required log files are non-empty #1463

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1421

/assign mansikulkarni96

This commit  adds a check to the logs tests to check that
log files have non-zero size, ensuring they are actually being
written to by the services.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2023

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug WINC-983 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["Number value expected as the Sprint id."],"errors":{}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #1421

/assign mansikulkarni96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@mansikulkarni96
Copy link
Member

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link
Author

@mansikulkarni96: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@aravindhp
Copy link
Contributor

/cherry-pick release-4.10

@mansikulkarni96 Please cherry pick from master for non bug PRs

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bc6ce07 and 2 for PR HEAD 0838689 in total

@aravindhp
Copy link
Contributor

/retest-required

azure-e2e-operator is failing because the VM is taking a long time to be configured. This is a flake we have seen in the past on Azure.

platform-none-vsphere-e2e-operator failed with:

INFO[2023-03-07T21:02:19Z] 2023-03-07 21:02:14+00:00 - Creating govc.sh file...
2023-03-07 21:02:14+00:00 - Creating vsphere_context.sh file...
2023-03-07 21:02:14+00:00 - Find virtual machines attached to ci-segment-58 and destroy
govc: POST "/sdk": 503 Service Unavailable 

which looks like a flake.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9729b36 and 1 for PR HEAD 0838689 in total

@sebsoto
Copy link
Contributor

sebsoto commented Mar 8, 2023

Cluster install failure
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4520bf0 into openshift:release-4.11 Mar 8, 2023
@openshift-cherrypick-robot
Copy link
Author

@mansikulkarni96: #1463 failed to apply on top of branch "release-4.10":

Applying: Ensure required log files are non-empty
Using index info to reconstruct a base tree...
M	test/e2e/logs_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/logs_test.go
CONFLICT (content): Merge conflict in test/e2e/logs_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure required log files are non-empty
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
…openshift-cherrypick-robot/cherry-pick-1421-to-release-4.11

Updated upstream source commit.
Commit details follow:

Signed-off-by: OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>
Project: https://github.com/openshift/windows-machine-config-operator.git
Branch:  release-4.11
Commit:  4520bf0
Author:  OpenShift Merge Robot
Date:    Wed, 8 Mar 2023 17:17:14 +0100

    Merge pull request openshift#1463 from openshift-cherrypick-robot/cherry-pick-1421-to-release-4.11

    [release-4.11] WINC-983: [e2e] Ensure required log files are non-empty

Additional included commits: 55bfac3, 2da90d3, 0838689, 9729b36

Referenced RedHat JIRA issues: OCPBUGS-8055, WINC-983

automerge: yes
x-md5: c69f9bf5c04d390019477488e87a1632
Change-Id: Ib12ff5739e997853cdbb96525f9ff5c27a6e45ed
mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
…7a1632' into 'rhaos-4.11-rhel-8'

Updated US source to: 4520bf0 Merge pull request openshift#1463 from openshift-cherrypick-robot/cherry-pick-1421-to-release-4.11

See merge request openshift-winc-midstream/openshift-winc-midstream!167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants