Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] OCPBUGS-10419: [metrics] Ignore case of cluster monitoring label #1497

Merged
merged 1 commit into from Apr 18, 2023
Merged

[release-4.10] OCPBUGS-10419: [metrics] Ignore case of cluster monitoring label #1497

merged 1 commit into from Apr 18, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1479

/assign saifshaikh48

@saifshaikh48
Ignore case of cluster monitoring label
1cd8e73 
This commit makes check for the monitoring label on the WMCO namespace accept
all valid string representations of booleans to provide better user experience.
Previously, not adhering to an all lowercase `true` value would result in WMCO
ignoring the label and not configuring Prometheus metrics for Windows nodes.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10222 has been cloned as Jira Issue OCPBUGS-10419. Will retitle bug to link to clone.
/retitle [release-4.10] OCPBUGS-10419: [metrics] Ignore case of cluster monitoring label

In response to this:

This is an automated cherry-pick of #1479

/assign saifshaikh48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] OCPBUGS-10222: [metrics] Ignore case of cluster monitoring label [release-4.10] OCPBUGS-10419: [metrics] Ignore case of cluster monitoring label Mar 16, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 16, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10419, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10222 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-10222 to target a version in 4.11.0, 4.11.z, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1479

/assign saifshaikh48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.10] OCPBUGS-10419: [metrics] Ignore case of cluster monitoring label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sebsoto
Copy link
Contributor

sebsoto commented Mar 17, 2023

/jira refresh

@openshift-ci-robot
Copy link

@sebsoto: This pull request references Jira Issue OCPBUGS-10419, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10418 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp
aravindhp reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@saifshaikh48
Copy link
Contributor

/jira refresh
/retest-required

@openshift-ci-robot
Copy link

@saifshaikh48: This pull request references Jira Issue OCPBUGS-10419, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10418 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 12, 2023
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Jira Issue OCPBUGS-10419, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10418 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10418 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from rrasouli April 12, 2023 18:29
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 792de5f and 2 for PR HEAD 1cd8e73 in total

@saifshaikh48
Copy link
Contributor

/retest-required

@saifshaikh48
Copy link
Contributor

/retest-required

1 similar comment
@saifshaikh48
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 185d733 into openshift:release-4.10 Apr 18, 2023
12 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10419: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10419 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1479

/assign saifshaikh48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@rrasouli rrasouli Awaiting requested review from rrasouli

Assignees

@aravindhp aravindhp

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @sebsoto @saifshaikh48 @mtnbikenc @aravindhp @openshift-merge-robot