-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-10933: Fix cleanup failure on WMCO upgrade #1527
[release-4.12] OCPBUGS-10933: Fix cleanup failure on WMCO upgrade #1527
Conversation
This commit rearranges the order of WMCO instance deconfiguration operations. It also updates the directory removal operation to delete the ksDir files excluding the WICD service related files. This allows us to retry reconciliation in case of a deletion failure, resulting in WICD cleanup cmd being called. k8sDir which only contains the WICD files is deleted as the last step in the directory cleanup process with best effort, logging any errors. At this point we don't want to retry reconciliation as the WICD files would have been deleted.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-10709 has been cloned as Jira Issue OCPBUGS-10933. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10933, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@mtnbikenc: This pull request references Jira Issue OCPBUGS-10933, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
aws-e2e-upgrade failed with:
For now we are seeing the error intermittently |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-10933: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-10933 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1511
/assign mansikulkarni96