-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-10935: Fix CNI conf #1528
[release-4.12] OCPBUGS-10935: Fix CNI conf #1528
Conversation
62dc2c3 introduced creating a CNI config with PascalCase moving away from the camelCase that was used previously generated. Generated is the key word here as the old template used PascalCase but the generated config was camelCase. This commit fixes the issue by adhering to the CNI config definition [0] for the win-overlay plugin. [0] https://www.cni.dev/plugins/current/main/win-overlay/
Introduce a test which ensures that pods can resolve cluster services through DNS. Co-authored-by: Sebastian Soto <ssoto@redhat.com>
@openshift-cherrypick-robot: Jira Issue OCPBUGS-10930 has been cloned as Jira Issue OCPBUGS-10935. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10935, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@mtnbikenc: This pull request references Jira Issue OCPBUGS-10935, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test azure-e2e-ccm-install Azure infra error:
|
/test wicd-unit-vsphere Timeout error that has been escalated and is fixed now:
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-10935: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-10935 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1623 |
This is an automated cherry-pick of #1526
/assign aravindhp