WINC-1040: Use Version annotation for service removal in WICD cleanup

[saifshaikh48]

This PR uses the version annotation instead of the desired version
as the source of truth when deconfiguring Windows services. This is
important to ensure there are no services left behind when upgrading,
if there is a change to the services CM spec between WMCO versions.

Using the desired version anno is kept as a backup operation if the node
does not have a version annotation (i.e. was not fully configured). This is
useful to recover when configuration fails and the instance needs to be reconciled.

[openshift-ci-robot]

@saifshaikh48: This pull request references WINC-1033 which is a valid jira issue.

In response to this:

This PR uses the version annotation instead of the desired version
as the source of truth when deconfiguring Windows services. This is
important to ensure there are no services left behind when upgrading,
if there is a change to the services CM spec between WMCO versions.

Using the desired version anno is kept as a backup operation if the node
does not have a version annotation (i.e. was not fully configured). This is
useful to recover when configuration fails and the instance needs to be reconciled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[alinaryan]

/lgtm

[openshift-ci-robot]

@saifshaikh48: No Jira issue with key WINC-1044 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

This PR uses the version annotation instead of the desired version
as the source of truth when deconfiguring Windows services. This is
important to ensure there are no services left behind when upgrading,
if there is a change to the services CM spec between WMCO versions.

Using the desired version anno is kept as a backup operation if the node
does not have a version annotation (i.e. was not fully configured). This is
useful to recover when configuration fails and the instance needs to be reconciled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@saifshaikh48: This pull request references WINC-1040 which is a valid jira issue.

In response to this:

This PR uses the version annotation instead of the desired version
as the source of truth when deconfiguring Windows services. This is
important to ensure there are no services left behind when upgrading,
if there is a change to the services CM spec between WMCO versions.

Using the desired version anno is kept as a backup operation if the node
does not have a version annotation (i.e. was not fully configured). This is
useful to recover when configuration fails and the instance needs to be reconciled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saifshaikh48, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sebsoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@saifshaikh48: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/nutanix-e2e-operator	7ba0459	link	false	/test nutanix-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[saifshaikh48]

/cherry-pick release-4.13

[saifshaikh48]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@saifshaikh48: new pull request created: #1588

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@saifshaikh48: new pull request created: #1589

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.