[release-4.12] WINC-1033: Use latest WICD binary during upgrades #1594
Conversation
Removes the unused credentials parameter from the method that copies over and ensures the WICD executable exists on an instance.
This commit ensures the WICD controller is not running before running WICD cleanup. This is needed if there is a node config failure after the WICD service is started -- it would continually try to restart services, clashing with `cleanup` which is trying to stop and remove them. It also makes it so that WMCO transfers over the WICD binary to the instance before running WICD cleanup. This ensures that in an upgrade scenario, the new version's WICD executable is used to cleanup. This is important so that WICD imporvements and bug fixes present in the new version are used during the upgrade flow.
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug WINC-1033 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["Number value expected as the Sprint id."],"errors":{}}
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold until WMCO 7.1.0 is released |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test aws-e2e-upgrade |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 90a3dd8
into
openshift:release-4.12
This is an automated cherry-pick of #1573
/assign saifshaikh48