Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINC-805: Add support for Windows Server 2022 in AWS #1604

Merged
merged 1 commit into from May 6, 2023

Conversation

aravindhp
Copy link
Contributor

@aravindhp aravindhp commented May 5, 2023

Update to openshift/ovn-kubernetes@a2eb4c3 which will pick up the fix for OCPBUGS-12971. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances. Once this PR merges, a follow up PR to the release repo will be required to actually start testing Windows Server 2022 on AWS.

Update to openshift/ovn-kubernetes@a2eb4c3

This commit was generated using hack/update_submodules.sh
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2023

@aravindhp: This pull request references WINC-805 which is a valid jira issue.

In response to this:

Update to openshift/ovn-kubernetes@a2eb4c3 which will pick up the fix for OCPBUGS-12971. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2023

@aravindhp: This pull request references WINC-805 which is a valid jira issue.

In response to this:

Update to openshift/ovn-kubernetes@a2eb4c3 which will pick up the fix for OCPBUGS-12971. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances. Once this PR merges, a follow up PR to the release repo will be required to actually start testing Windows Server 2022 on AWS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2023

@aravindhp: This pull request references WINC-805 which is a valid jira issue.

In response to this:

Update to openshift/ovn-kubernetes@a2eb4c3 which will pick up the fix for OCPBUGS-12971. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances. Once this PR merges, a follow up PR to the release repo will be required to actually start testing Windows Server 2022 on AWS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@aravindhp
Copy link
Contributor Author

/approve cancel

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
aravindhp added a commit to aravindhp/release that referenced this pull request May 5, 2023
Test Windows Server 2022 on AWS now that OCPBUGS-12971 has been fixed
and openshift/windows-machine-config-operator#1604 has merged.
@saifshaikh48
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
@alinaryan
Copy link
Contributor

LGTM

@aravindhp
Copy link
Contributor Author

/test nutanix-e2e-operator

Failed during bootstrapping:

E0505 18:47:19.869489    1515 reflector.go:140] k8s.io/client-go/tools/watch/informerwatcher.go:146: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: Get "https://api.ci-op-p1sttwmy-5c595.nutanix-ci.devcluster.openshift.com:6443/api/v1/namespaces/kube-system/configmaps?fieldSelector=metadata.name%3Dbootstrap&resourceVersion=5318": tls: failed to verify certificate: x509: certificate is valid for kubernetes, kubernetes.default, kubernetes.default.svc, kubernetes.default.svc.cluster.local, openshift, openshift.default, openshift.default.svc, openshift.default.svc.cluster.local, 10.128.0.1, not api.ci-op-p1sttwmy-5c595.nutanix-ci.devcluster.openshift.com

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD af3ea3b and 2 for PR HEAD c4fc364 in total

@aravindhp
Copy link
Contributor Author

/hold

For #1586 to merge as we can't test openshift/release#39069 without that

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023
@aravindhp
Copy link
Contributor Author

/unhold

#1586 is having issues that need to be investigated

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e996410 and 1 for PR HEAD c4fc364 in total

@aravindhp
Copy link
Contributor Author

/retest-required

Took too long to get a GCP lease and the test hit the 4 hour limit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2023

@aravindhp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0ba5983 into openshift:master May 6, 2023
15 checks passed
@aravindhp aravindhp deleted the WINC-805 branch May 8, 2023 15:56
openshift-merge-robot pushed a commit to openshift/release that referenced this pull request May 11, 2023
Test Windows Server 2022 on AWS now that OCPBUGS-12971 has been fixed
and openshift/windows-machine-config-operator#1604 has merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants