Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19502: Enable proxy removal test #1800

Merged
merged 1 commit into from
Oct 22, 2023
Merged

OCPBUGS-19502: Enable proxy removal test #1800

merged 1 commit into from
Oct 22, 2023

Conversation

mansikulkarni96
Copy link
Member

@mansikulkarni96 mansikulkarni96 commented Sep 15, 2023 •
edited

This PR enables running proxy removal test which was disabled due to its unreliable behavior.
It has now been modified to wait for the reboot annotation to be applied and to be removed before running the tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator
build pod timed out.

@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96 mansikulkarni96 changed the title WIP: Fix proxy test skip Fix proxy tests being skipped Sep 19, 2023
@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96 mansikulkarni96 changed the title Fix proxy tests being skipped OCPBUGS-19502: Fix proxy tests being skipped Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link

@mansikulkarni96: This pull request references Jira Issue OCPBUGS-19502, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Jira Issue OCPBUGS-19502, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96 mansikulkarni96 force-pushed the fixProxyTests branch 2 times, most recently from bca4737 to ec9f946 Compare September 20, 2023 19:07
@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

2 similar comments
@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96 mansikulkarni96 force-pushed the fixProxyTests branch 2 times, most recently from ce5a812 to 3db41ca Compare September 21, 2023 22:19
@mansikulkarni96
Copy link
Member Author

/test vsphere-proxy-e2e-operator

@mansikulkarni96
Copy link
Member Author

/retest-required

@mansikulkarni96
Copy link
Member Author

/test aws-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test azure-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test gcp-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test nutanix-e2e-operator

@mansikulkarni96
Copy link
Member Author

/test all

@mansikulkarni96
Copy link
Member Author

/test aws-e2e-upgrade

@mansikulkarni96
Copy link
Member Author

/test all

@mansikulkarni96
Copy link
Member Author

/retest-required

@mansikulkarni96
Copy link
Member Author

/test wicd-unit-vsphere
/test ci-index-wmco-bundle

@mansikulkarni96
Copy link
Member Author

/test platform-none-vsphere-e2e-operator
/test vsphere-e2e-operator

@aravindhp
Copy link
Contributor

/retest-required

All vSphere jobs failed with Job execution failed: Pod got deleted unexpectedly

@mansikulkarni96
Copy link
Member Author

/retest-required

2 similar comments
@aravindhp
Copy link
Contributor

/retest-required

@mansikulkarni96
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cbc3f47 and 0 for PR HEAD e7e7268 in total

@openshift-ci-robot
Copy link

/hold

Revision e7e7268 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2023
@aravindhp
Copy link
Contributor

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2023
@jrvaldes
Copy link
Contributor

/test vsphere-proxy-e2e-operator

image build failed to pull from the registry.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cbc3f47 and 2 for PR HEAD e7e7268 in total

@aravindhp
Copy link
Contributor

/test security

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2023

@mansikulkarni96: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit f452bc7 into openshift:master Oct 22, 2023
16 checks passed
@openshift-ci-robot
Copy link

@mansikulkarni96: Jira Issue OCPBUGS-19502: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19502 has been moved to the MODIFIED state.

In response to this:

This PR enables running proxy removal test which was disabled due to its unreliable behavior.
It has now been modified to wait for the reboot annotation to be applied and to be removed before running the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mansikulkarni96: #1800 failed to apply on top of branch "release-4.14":

Applying: Enable proxy removal test
Using index info to reconstruct a base tree...
M	test/e2e/delete_test.go
M	test/e2e/proxy_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/proxy_test.go
CONFLICT (content): Merge conflict in test/e2e/proxy_test.go
Auto-merging test/e2e/delete_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Enable proxy removal test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2023
Merged
@openshift-cherrypick-robot
Copy link

@mansikulkarni96: new pull request created: #1916

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@rrasouli rrasouli Awaiting requested review from rrasouli

@sebsoto sebsoto Awaiting requested review from sebsoto

@aravindhp aravindhp Awaiting requested review from aravindhp

Assignees

@sebsoto sebsoto

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mansikulkarni96 @openshift-ci-robot @mtnbikenc @aravindhp @saifshaikh48 @openshift-merge-robot @openshift-cherrypick-robot @sebsoto @jrvaldes