Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master submodule update 09 27 #1836

Closed
wants to merge 2 commits into from
Closed

Master submodule update 09 27 #1836

wants to merge 2 commits into from

Conversation

wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Sep 27, 2023 •
edited

[submodule][containernetworking-plugins] Update to 80a8df05
[submodule][cloud-provider-azure] Update to 1148bff65

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign sebsoto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes
Copy link
Contributor

jrvaldes commented Sep 27, 2023 •
edited

@wgahnagl something is not right with the latest combination of ovn-kubernetes and kubelet submodules update. hybrid-overlay is failing with

E0927 19:37:53.178022    4932 kube.go:130] Error in setting annotation on node ci-op-56c3qr7h-8411c-wdmq9-e2e-wm-xs6sc: admission webhook "node.network-node-identity.openshift.io" denied the request: user "system:node:ci-op-56c3qr7h-8411c-wdmq9-e2e-wm-xs6sc" is not allowed to set the following annotations on node: "ci-op-56c3qr7h-8411c-wdmq9-e2e-wm-xs6sc": [k8s.ovn.org/hybrid-overlay-distributed-router-gateway-mac]

However, the Windows job passed in the other side.

@wgahnagl
Copy link
Contributor Author

https://issues.redhat.com/browse/OCPBUGS-19900
is blocking the merge

@jrvaldes
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2023
aravindhp
aravindhp suggested changes Sep 28, 2023
View reviewed changes
Makefile Outdated
@@ -7,7 +7,7 @@ WMCO_VERSION ?= 10.15.0

# *_GIT_VERSION are the k8s versions. Any update to the build line could potentially require an update to the sed
# command in generate_k8s_version_commit() in hack/update_submodules.sh
KUBELET_GIT_VERSION=v1.27.4+681e724
KUBELET_GIT_VERSION=v1.28.2+e3ba6d9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this commit

ovn-kubernetes Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the blocking issue, it will be best to remove this and get rest of the submodules in.

@sebsoto
Copy link
Contributor

sebsoto commented Sep 29, 2023

This PR should go in after #1849
ovn update should be removed

@aravindhp aravindhp marked this pull request as draft September 29, 2023 17:56
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2023
@aravindhp
Copy link
Contributor

@wgahnagl please address all comments and move this out of draft

@wgahnagl
[submodule][containernetworking-plugins] Update to 80a8df05
209fc48 
Update to openshift/containernetworking-plugins@80a8df0

This commit was generated using hack/update_submodules.sh
@wgahnagl
[submodule][cloud-provider-azure] Update to 1148bff65
0444a76 
Update to openshift/cloud-provider-azure@1148bff

This commit was generated using hack/update_submodules.sh
@wgahnagl wgahnagl force-pushed the master-submodule-update-09-27 branch from bbb55de to 0444a76 Compare October 3, 2023 17:25
@wgahnagl wgahnagl marked this pull request as ready for review October 3, 2023 17:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2023
@openshift-ci openshift-ci bot requested a review from aravindhp October 3, 2023 17:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/vsphere-e2e-operator 0444a76 link true /test vsphere-e2e-operator
ci/prow/vsphere-proxy-e2e-operator 0444a76 link true /test vsphere-proxy-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alinaryan
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this Oct 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

@alinaryan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@aravindhp aravindhp Awaiting requested review from aravindhp

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wgahnagl @jrvaldes @sebsoto @aravindhp @alinaryan