[release-4.15] OCPBUGS-27239: [cluster] Keep comma as delimiter in noProxy list #2015
Conversation
Reverts an erroneous sanitization step in WMCO that replaced commas with semicolons in the user's cluster-wide proxy configuration. This was causing Windows to ignore the values set in the noProxy environment variable, incorrectly sending traffic through the proxy. From the Azure PowerShell docs: `NO_PROXY: a comma-separated list of hostnames that should be excluded from proxying.` `noProxy list should not contain semicolon delimiters (;). Use (,) to delimit the noProxy domains.`
This commit adds a new set of subtests to the proxy suite. The first ensures that default outbound requests use the proxy variables and actually are routed through the proxy by investigating curl headers. The second ensures that hitting an endpoint that is under the NO_PROXY list does not go through the proxy server.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-24264 has been cloned as Jira Issue OCPBUGS-27239. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-27239, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mansikulkarni96, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test remaining-required |
|
/lgtm |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 5147e86
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-27239: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27239 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@saifshaikh48 Shouldn't this be backported to release-4.14 next? |
|
/cherry-pick release-4.14 @mtnbikenc I had created cherry-picked into 4.14 from the master PR, will close that one and open from here |
|
@saifshaikh48: new pull request created: #2023 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1998
/assign saifshaikh48