Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-28253: Use DSR load balancing in kube-proxy #2042

Merged
merged 5 commits into from Feb 5, 2024
Merged

[release-4.13] OCPBUGS-28253: Use DSR load balancing in kube-proxy #2042

merged 5 commits into from Feb 5, 2024

Conversation

sebsoto
Copy link
Contributor

@sebsoto sebsoto commented Jan 25, 2024 •
edited by mtnbikenc

Manual cherry-pick of #2041

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@sebsoto
Copy link
Contributor Author

sebsoto commented Jan 25, 2024

/approve cancel

@sebsoto
Copy link
Contributor Author

sebsoto commented Jan 25, 2024

/test remaining-required

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@sebsoto
Switch to DSR load balancing
4db356d 
The port reservation logic in kube-proxy's dsr mode is better tested.
Without using DSR, packet loss was being seen by on Windows Server 2019.
@sebsoto
Add Windows Exporter port to firewall
a6506d1 
Explicity allows incoming traffic for the Windows Exporter metrics
server running on Windows nodes.
@sebsoto
Refactor machine approver scaling
dde581f 
Adds new function to help scale up/down the cluster machine approver
deployment.
@sebsoto
Fix upgrade test for Machine recreation
ebee5a9 
Adjusts the update test ensure it works when Machines are recreated as
part of an upgrade. This will happen when the userdata is changed
between two releases. The existing problems are that the Cluster Machine
Approver needs to be scaled so CSRs can be approved, and that storage
workloads which are being used to test across upgrades need to not be
assigned a Node affinity. If there is an affinity on the Node that is
replaced, the workload will not be able to be rescheduled.
@sebsoto
Copy link
Contributor Author

sebsoto commented Jan 26, 2024

/jira cherrypick OCPBUGS-28226

@openshift-ci-robot
Copy link

@sebsoto: Jira Issue OCPBUGS-28226 has been cloned as Jira Issue OCPBUGS-28253. Will retitle bug to link to clone.
/retitle OCPBUGS-28253: Dsr cherrypick413

In response to this:

/jira cherrypick OCPBUGS-28226

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Dsr cherrypick413 OCPBUGS-28253: Dsr cherrypick413 Jan 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link

@sebsoto: This pull request references Jira Issue OCPBUGS-28253, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28226 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtnbikenc mtnbikenc changed the title OCPBUGS-28253: Dsr cherrypick413 [release-4.13] OCPBUGS-28253: Use DSR load balancing in kube-proxy Jan 26, 2024
@sebsoto
Copy link
Contributor Author

sebsoto commented Jan 28, 2024

/test remaining-required

@mansikulkarni96
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@mtnbikenc
Copy link
Member

/retest-required

1 similar comment
@mtnbikenc
Copy link
Member

/retest-required

@mtnbikenc
Copy link
Member

azure setup failed
/test azure-e2e-upgrade

@mtnbikenc
Copy link
Member

There appears to be a problem in the azure-e2e-upgrade test. It is failing consistently for this PR while waiting for workloads to scale.

@mtnbikenc
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 5, 2024
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Jira Issue OCPBUGS-28253, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28226 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28226 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 5, 2024
@openshift-ci openshift-ci bot requested a review from rrasouli February 5, 2024 13:45
@sebsoto sebsoto marked this pull request as ready for review February 5, 2024 14:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 09678c7 and 2 for PR HEAD ebee5a9 in total

@sebsoto
[test] Change how upgrade-blocked Node is labeled
f5cef33 
Changes how the upgrade blocked Node is labeled when doing an in-tree to
csi storage upgrade. This is required to stop the use of affinities,
which will cause issues across WMCO upgrade in the case that Machine
Nodes have to be recreated. If the Machine Node is replaced, the pod
will be unschedulable, as it will only run on the deleted Node.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@sebsoto
Copy link
Contributor Author

sebsoto commented Feb 5, 2024

/test remaining-required

@sebsoto
Copy link
Contributor Author

sebsoto commented Feb 5, 2024

/retest-required

wgahnagl
wgahnagl reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@wgahnagl wgahnagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/vsphere-golden-image.md

Create a new firewall rule in the Windows VM to allow incoming connections for container logs, usually
on TCP port `10250` by running the following PowerShell command:
Create new firewall rules in the Windows VM to allow incoming connections for container logs and metrics:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would it be good to still call out the "usually on TCP port x" here?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 09678c7 and 2 for PR HEAD f5cef33 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@sebsoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ff5cd4c into openshift:release-4.13 Feb 5, 2024
15 checks passed
@openshift-ci-robot
Copy link

@sebsoto: Jira Issue OCPBUGS-28253: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28253 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #2041

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wgahnagl wgahnagl wgahnagl left review comments

@rrasouli rrasouli Awaiting requested review from rrasouli

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

Assignees

@wgahnagl wgahnagl

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sebsoto @openshift-ci-robot @mansikulkarni96 @mtnbikenc @wgahnagl