Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] WINC-1113: Introduce feature annotations to CSV #2085

Merged

Conversation

alinaryan
Copy link
Contributor

Adds infrastructure-related annotations: 'features.operators.openshift.io/*' to the operator CSV file, and sets each to string 'true' or 'false' for the WMCO bundle to pass the new CVP Operator Infrastructure Feature Test in the Operator Bundle Image Validation pipeline.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2024

@alinaryan: This pull request references WINC-1113 which is a valid jira issue.

In response to this:

Adds infrastructure-related annotations: 'features.operators.openshift.io/*' to the operator CSV file, and sets each to string 'true' or 'false' for the WMCO bundle to pass the new CVP Operator Infrastructure Feature Test in the Operator Bundle Image Validation pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@alinaryan
Copy link
Contributor Author

/test build

@alinaryan alinaryan marked this pull request as ready for review February 21, 2024 15:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
This commit adds infrastructure-related annotations:
'features.operators.openshift.io/*' to the operator CSV file,
and sets each to string 'true' or 'false' for the WMCO bundle
to pass the new CVP Operator Infrastructure Feature Test
in the Operator Bundle Image Validation pipeline.

Signed-off-by: Alina Ryan <aliryan@redhat.com>
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@alinaryan
Copy link
Contributor Author

/test remaining-required

@mansikulkarni96
Copy link
Member

/approve

@alinaryan
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alinaryan, mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3df0155 and 2 for PR HEAD 3ec0751 in total

Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

@alinaryan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 81081e9 into openshift:release-4.13 Feb 22, 2024
15 checks passed
@alinaryan
Copy link
Contributor Author

/cherry-pick release-4.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants