Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] WINC-1113: Introduce feature annotations to CSV #2086

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[release-4.12] WINC-1113: Introduce feature annotations to CSV #2086

merged 1 commit into from
Feb 28, 2024

Conversation

alinaryan
Copy link
Contributor

Adds infrastructure-related annotations: 'features.operators.openshift.io/*' to the operator CSV file, and sets each to string 'true' or 'false' for the WMCO bundle to pass the new CVP Operator Infrastructure Feature Test in the Operator Bundle Image Validation pipeline.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2024 •
edited by openshift-ci bot

@alinaryan: This pull request references WINC-1113 which is a valid jira issue.

In response to this:

Adds infrastructure-related annotations: 'features.operators.openshift.io/*' to the operator CSV file, and sets each to string 'true' or 'false' for the WMCO bundle to pass the new CVP Operator Infrastructure Feature Test in the Operator Bundle Image Validation pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@alinaryan
Copy link
Contributor Author

/test build

@alinaryan alinaryan marked this pull request as ready for review February 21, 2024 15:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
saifshaikh48
saifshaikh48 reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@alinaryan
Copy link
Contributor Author

/test remaining-required

@mansikulkarni96
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alinaryan, mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a42a36c and 2 for PR HEAD 8377211 in total

@jrvaldes
Copy link
Contributor

/test gcp-e2e-operator

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a56c3aa and 1 for PR HEAD 8377211 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@mansikulkarni96
Copy link
Member

@alinaryan please revisit the rebase, there are some markers left behind.

@jrvaldes
Copy link
Contributor

/test gcp-e2e-operator

@sebsoto
Copy link
Contributor

sebsoto commented Feb 27, 2024

/hold
This change needs to be made in https://github.com/openshift/windows-machine-config-operator/blob/master/config/manifests/bases/windows-machine-config-operator.clusterserviceversion.yaml
The bundle/ directory is generated from config/

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@alinaryan
Copy link
Contributor Author

/hold

@alinaryan
[release-4.12] WINC-1113: Introduce feature annotations to CSV
51174e4 
This commit adds infrastructure-related annotations:
'features.operators.openshift.io/*' to the operator config
CSV file, and sets each to string 'true' or 'false' for
the WMCO bundle to pass the new CVP Operator Infrastructure
Feature Test in the Operator Bundle Image Validation pipeline.

Ran:
'make bundle'

Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan
Copy link
Contributor Author

/test remaining-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@alinaryan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alinaryan
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@wgahnagl
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9070600 into openshift:release-4.12 Feb 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@wgahnagl wgahnagl

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@alinaryan @openshift-ci-robot @mansikulkarni96 @jrvaldes @sebsoto @wgahnagl @saifshaikh48 @openshift-merge-robot