Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] WINC-1113: Followup #2097

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[release-4.15] WINC-1113: Followup #2097

merged 1 commit into from
Mar 1, 2024

Conversation

alinaryan
Copy link
Contributor

Adds infrastructure-related annotations: 'features.operators.openshift.io/*' to the operator config CSV file, and sets each to string 'true' or 'false' for the WMCO bundle to pass the new CVP Operator Infrastructure Feature Test in the Operator Bundle Image Validation pipeline.

Ran:
'make bundle'

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2024 •
edited by openshift-ci bot

@alinaryan: This pull request references WINC-1113 which is a valid jira issue.

In response to this:

Adds infrastructure-related annotations: 'features.operators.openshift.io/*' to the operator config CSV file, and sets each to string 'true' or 'false' for the WMCO bundle to pass the new CVP Operator Infrastructure Feature Test in the Operator Bundle Image Validation pipeline.

Ran:
'make bundle'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@alinaryan alinaryan force-pushed the followup-release-4.15-WINC-1113 branch 2 times, most recently from 5d21da3 to c4b5549 Compare February 28, 2024 20:53
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@alinaryan
Copy link
Contributor Author

/test remaining-required

saifshaikh48
saifshaikh48 reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@alinaryan
Copy link
Contributor Author

/retest-required

@sebsoto
Copy link
Contributor

sebsoto commented Feb 29, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alinaryan, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 853c3b7 and 2 for PR HEAD c4b5549 in total

@alinaryan
[release-4.15] WINC-1113: Followup
a3d06cd 
This commit adds infrastructure-related annotations:
'features.operators.openshift.io/*' to the operator config
CSV file, and sets each to string 'true' or 'false' for
the WMCO bundle to pass the new CVP Operator Infrastructure
Feature Test in the Operator Bundle Image Validation pipeline.

Ran:
'make bundle'

Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan alinaryan force-pushed the followup-release-4.15-WINC-1113 branch from c4b5549 to a3d06cd Compare February 29, 2024 20:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@alinaryan
Copy link
Contributor Author

/test remaining-required

saifshaikh48
saifshaikh48 reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

nit on the PR/commit title, it can be updated to be more descriptive

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 853c3b7 and 2 for PR HEAD a3d06cd in total

@jrvaldes
Copy link
Contributor

jrvaldes commented Mar 1, 2024

/retest-required

1 similar comment
@alinaryan
Copy link
Contributor Author

/retest-required

@jrvaldes
Copy link
Contributor

jrvaldes commented Mar 1, 2024

/hold

to investigate CI failures in vsphere

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@mansikulkarni96
Copy link
Member

/override platform-none-vsphere-e2e-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@mansikulkarni96: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • platform-none-vsphere-e2e-operator

Only the following failed contexts/checkruns were expected:

  • ci/prow/aws-e2e-operator
  • ci/prow/aws-e2e-upgrade
  • ci/prow/azure-e2e-operator
  • ci/prow/azure-e2e-upgrade
  • ci/prow/build
  • ci/prow/ci-bundle-wmco-bundle
  • ci/prow/gcp-e2e-operator
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/nutanix-e2e-operator
  • ci/prow/platform-none-vsphere-e2e-operator
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vsphere-e2e-operator
  • ci/prow/vsphere-proxy-e2e-operator
  • ci/prow/wicd-unit-vsphere
  • pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-upgrade
  • pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-upgrade
  • pull-ci-openshift-windows-machine-config-operator-master-build
  • pull-ci-openshift-windows-machine-config-operator-master-ci-bundle-wmco-bundle
  • pull-ci-openshift-windows-machine-config-operator-master-gcp-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-images
  • pull-ci-openshift-windows-machine-config-operator-master-lint
  • pull-ci-openshift-windows-machine-config-operator-master-nutanix-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-platform-none-vsphere-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-security
  • pull-ci-openshift-windows-machine-config-operator-master-unit
  • pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-wicd-unit-vsphere
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override platform-none-vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alinaryan
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@mansikulkarni96
Copy link
Member

/override ci/prow/platform-none-vsphere-e2e-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@mansikulkarni96: Overrode contexts on behalf of mansikulkarni96: ci/prow/platform-none-vsphere-e2e-operator

In response to this:

/override ci/prow/platform-none-vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96
Copy link
Member

/override ci/prow/vsphere-proxy-e2e-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@mansikulkarni96: Overrode contexts on behalf of mansikulkarni96: ci/prow/vsphere-proxy-e2e-operator

In response to this:

/override ci/prow/vsphere-proxy-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96
Copy link
Member

/override ci/prow/vsphere-e2e-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@mansikulkarni96: Overrode contexts on behalf of mansikulkarni96: ci/prow/vsphere-e2e-operator

In response to this:

/override ci/prow/vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@alinaryan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/vsphere-proxy-e2e-operator a3d06cd link true /test vsphere-proxy-e2e-operator
ci/prow/platform-none-vsphere-e2e-operator a3d06cd link true /test platform-none-vsphere-e2e-operator
ci/prow/vsphere-e2e-operator a3d06cd link true /test vsphere-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 771a607 into openshift:release-4.15 Mar 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alinaryan @openshift-ci-robot @sebsoto @jrvaldes @mansikulkarni96 @saifshaikh48 @openshift-merge-robot