OCPBUGS-20255: Let caller of Run handle error logging #2115
Conversation
Stops logging within windows.Run(), and instead lets the caller decide to log. This stops the undesired logging of errors, in the case that Run() is expected to fail.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
jira/severity-moderate
|
@sebsoto: This pull request references Jira Issue OCPBUGS-20255, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/test aws-e2e-operator |
openshift-ci
bot
added
the
approved
|
/approve cancel |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
approved
|
/approve |
openshift-ci
bot
added
the
approved
|
/test remaining-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if !(strings.Contains(cmd, serviceQueryCmd) && strings.Contains(out, serviceNotFound)) && | ||
| !(strings.Contains(err.Error(), cmdExitNoStatus) && strings.HasSuffix(cmd, removeHNSCommand+";\"")) { | ||
| vm.log.Error(err, "error running", "cmd", cmd, "out", out) | ||
| } |
There was a problem hiding this comment.
Is there going to be a follow-up PR to re-introduce this log at the call site(s)?
There was a problem hiding this comment.
Is there any call in particular you are worried about?
All uses of Run() log the error through reconcile failures. Many log the output explicitly as well.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cherry-pick release-4.15 |
|
@sebsoto: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test vsphere-proxy-e2e-operator |
|
/retest-required |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/restest-required |
|
/test azure-e2e-upgrade |
|
@sebsoto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sebsoto: Jira Issue OCPBUGS-20255: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20255 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sebsoto: new pull request created: #2124 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stops logging within windows.Run(), and instead lets the caller decide to log. This stops the undesired logging of errors, in the case that Run() is expected to fail.