[release-4.14] OCPBUGS-32136: Enable kubelet ECR authentiation #2134
Conversation
Builds and ships ecr-credential-provider.exe
Refactors how files are collected from ignition. This is to make the function less fragile, and allow for special casing to be added to certain files.
This commit copies the CredentialProviderConfig present in ignition to each Windows instance. It also changes kubelet args to give a path for the config, as well as a directory for any credential provider binaries referenced by the config. On AWS ecr-credential-provider.exe will be copied to the instance, enabling authentication to ECR registries, as long as the cluster admin has changed the worker node IAM role to allow for this.
go mod tidy && go mod vendor
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/jira cherrypick OCPBUGS-31635 |
|
@sebsoto: Jira Issue OCPBUGS-31635 has been cloned as Jira Issue OCPBUGS-32136. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@sebsoto: This pull request references Jira Issue OCPBUGS-32136, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
sebsoto
changed the title
|
/approve cancel |
openshift-ci
bot
removed
the
approved
|
/jira refresh |
|
@sebsoto: An error was encountered updating to the POST state for bug OCPBUGS-32136 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Post "https://issues.redhat.com/rest/api/2/issue/15937176/transitions": POST https://issues.redhat.com/rest/api/2/issue/15937176/transitions giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@sebsoto: This pull request references Jira Issue OCPBUGS-32136, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test images |
|
/test remaining-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest-required |
|
/test nutanix-e2e-operator |
|
@sebsoto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 84e2aff
into
openshift:release-4.14
|
@sebsoto: Jira Issue OCPBUGS-32136: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32136 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fixes a bug where authentication with ECR registries through the kubelet was no longer possible.
Manual cherry-pick of #2119