Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes #370

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes #370

merged 1 commit into from
Mar 31, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #323

/assign sebsoto

@sebsoto
Fix pubkey hash annotation logic
b37ba27 
This commit fixes an issue where the public key hash annotation was being
added to not all nodes, not just Windows nodes. This commit also adds
logic to remove the annotation from Linux nodes when the operator is
installed.

As part of this fix, Windows node selection in the secret controller
now uses the label "kubernetes.io/os=windows". There is a mix of this
label and "node.openshift.io/os_id=Windows" in the node selection logic
throughout WMCO, and we should move towards just using one. Future work
should be done to only use the "kubernetes.io/os" label for node
selection throughout WMCO.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 31, 2021
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1930791 has been cloned as Bugzilla bug 1945248. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes

In response to this:

[release-4.7] Bug 1930791: [wmco] Stop adding pub-key-hash label to all nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sebsoto
Copy link
Contributor

sebsoto commented Mar 31, 2021

/retitle Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1930791: [wmco] Stop adding pub-key-hash label to all nodes [release-4.7] Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes Mar 31, 2021
@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes Mar 31, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 31, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1945248, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1930791 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1930791 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp
aravindhp approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit deff43e into openshift:release-4.7 Mar 31, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1945248 has been moved to the MODIFIED state.

In response to this:

Bug 1945248: [wmco] Stop adding pub-key-hash label to all nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@sebsoto sebsoto Awaiting requested review from sebsoto

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

Assignees

@sebsoto sebsoto

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @sebsoto @mansikulkarni96 @openshift-bot @aravindhp @openshift-merge-robot