-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[community-4.7][wmco] Stop adding pub-key-hash label to all nodes #371
[community-4.7][wmco] Stop adding pub-key-hash label to all nodes #371
Conversation
This commit fixes an issue where the public key hash annotation was being added to not all nodes, not just Windows nodes. This commit also adds logic to remove the annotation from Linux nodes when the operator is installed. As part of this fix, Windows node selection in the secret controller now uses the label "kubernetes.io/os=windows". There is a mix of this label and "node.openshift.io/os_id=Windows" in the node selection logic throughout WMCO, and we should move towards just using one. Future work should be done to only use the "kubernetes.io/os" label for node selection throughout WMCO.
@openshift-cherrypick-robot: Could not make automatic cherrypick of Bugzilla bug 1930791 for this PR as the target_release is not set for this branch in the bugzilla plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle [community-4.7][wmco] Stop adding pub-key-hash label to all nodes |
@openshift-ci-robot: This pull request references Bugzilla bug 1930791, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sebsoto: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This is an automated cherry-pick of #323
/assign sebsoto