[community-4.8] [wmco] WINC-631: BYOH controller is able to react to changes in Node objects #543
Conversation
This commit makes it so that the ConfigMap controller watches all BYOH nodes, and ensures that the Machine controller does not attempt to reconcile BYOH nodes.
This commit moves adding of all annotations, besides the version annotation, to right after the inital kubelet configuration. This allows nodes to be identified as BYOH nodes in the case that confuration fails part way through.
This commit ensures that BYOH nodes that were partially configured are properly dealt with. The reconfiguration suite was expanded to include reconfiguration of one Machine sourced node, and one BYOH node. Before this commit, if an instance was far enough along in the configuration process that a node object was created for it, and then the configuration failed, the instance would be left in a partially configured and unusable state, unless the node was manually deleted.
|
/lgtm |
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This is an automated cherry-pick of #479
/assign sebsoto