[release-4.8] [wmco] WINC-631: BYOH controller is able to react to changes in Node objects #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it so that the ConfigMap controller watches all BYOH nodes, and ensures that the Machine controller does not attempt to reconcile BYOH nodes.
This commit moves adding of all annotations, besides the version annotation, to right after the inital kubelet configuration. This allows nodes to be identified as BYOH nodes in the case that confuration fails part way through.
This commit ensures that BYOH nodes that were partially configured are properly dealt with. The reconfiguration suite was expanded to include reconfiguration of one Machine sourced node, and one BYOH node. Before this commit, if an instance was far enough along in the configuration process that a node object was created for it, and then the configuration failed, the instance would be left in a partially configured and unusable state, unless the node was manually deleted.
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mansikulkarni96
pushed a commit
to mansikulkarni96/windows-machine-config-operator
that referenced
this pull request
Aug 7, 2023
…penshift-cherrypick-robot/cherry-pick-479-to-release-4.8 Updated upstream source commit. Commit details follow: Project: https://github.com/openshift/windows-machine-config-operator.git Branch: release-4.8 Commit: 8d5d786 Author: openshift-ci[bot] Date: Wed, 11 Aug 2021 18:37:55 +0000 Merge pull request openshift#578 from openshift-cherrypick-robot/cherry-pick-479-to-release-4.8 [release-4.8] [wmco] WINC-631: BYOH controller is able to react to changes in Node objects automerge: yes x-md5: 0e68e95ae5be67c3924b88524725115c Change-Id: I33d3029aa48cb96298211a2d85e3fa93d0b10635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #479
/assign mansikulkarni96