[release-4.8] WINC-650: [wmco] Apply worker role to BYOH Nodes #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves everything that was present in the annotations package into the metadata package. This is being done as we will need to use the functions present in the annotations package for labels as well, and it makes more sense to generalize the functions considering the similarities between annotations and labels.
Refactors the patch creation in order to enable better unit testing. Specifically, this commit makes it so that metadata.generatePatch no longer returns the marshalled patches, but instead returns the slice of patches it generated, allowing those to be marshalled at the call sites, metadata.GenerateAddPatch() and metadata.GenerateRemovePatch(). This commit is important for two reasons. Firstly, using assert.elementsMatch to test that a byte slice is correct does not seem like the right thing to do. This seems as if it just tests that the chars are all the same, so the patchdata could be made out of order and this unit test would not catch that. Secondly this allows for more complex testing, which will be required in a future commit where generatePatch() handles both annotations and labels. Additionally, since the tests had to be changed, I changed one case to exercise the escaping functionality, something that was being missed by the tests.
Extends the annotation patch creation functions to allow for labels as well.
The machine-api-controller does this for Nodes associated with Machines, this needed to be done for BYOH Nodes as well.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #541
/assign mansikulkarni96