Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: [docs] VSphere golden image for airgapped network #601

Closed
wants to merge 1 commit into from
Closed

WIP: [docs] VSphere golden image for airgapped network #601

wants to merge 1 commit into from

Conversation

jrvaldes
Copy link
Contributor

Include instructions to pre-pull the Pause Image into the golden
image during the creation process, to support disconnected network
environments.

Follow-up for #579

@jrvaldes
[docs] VSphere golden image for airgapped network
7965a98 
Include instructions to pre-pull the Pause Image into the golden
image during the creation process, to support disconnected network
environments.

Follow-up for openshift#579
@jrvaldes
Copy link
Contributor Author

/cc @EricPonvelle

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
To complete the pull request process, please assign sebsoto after the PR has been reviewed.
You can assign the PR to them by writing /assign @sebsoto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saifshaikh48
saifshaikh48 reviewed Aug 16, 2021
View reviewed changes
docs/vsphere-golden-image.md
@@ -129,6 +129,17 @@ Install the `docker` container runtime following the [Microsoft's documentation]
Alternatively, you can run the provided PowerShell script [install-docker.ps1](vsphere_ci/scripts/install-docker.ps1)
to programmatically install `docker` in the Windows VM.

### Set up for disconnected network environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could someone using another cloud provider also be interested in this step? Just wondering if this should be in a more generic place (like the top-level README)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, given the creation of a golden image is only a pre-req for vSphere; here is definitely a good fit for this.
As per OpenShift docs, restricted network is also supported in AWS with IPI, not the case for Azure.

@aravindhp
Copy link
Contributor

/hold

until the actual work can be prioritized and tested

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@jrvaldes jrvaldes changed the title [docs] VSphere golden image for airgapped network WIP: [docs] VSphere golden image for airgapped network Oct 6, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2021
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jrvaldes jrvaldes closed this Mar 17, 2022
@jrvaldes jrvaldes deleted the docs-vsphere-pre-pull-pause-image branch March 17, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@EricPonvelle EricPonvelle Awaiting requested review from EricPonvelle

@aravindhp aravindhp Awaiting requested review from aravindhp

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrvaldes @aravindhp @openshift-bot @saifshaikh48