Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] WINC-648: [wmco] Remove HNS networks in BYOH deconfiguration #610

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #574

/assign mansikulkarni96

mansikulkarni96 and others added 2 commits August 18, 2021 02:59
The hybrid-overlay process creates HNS networks when it runs
on a node. This commit removes the HNS networks created by
previous configuration on the node and adds a test case
in the deletion test suite to test the removal.
This tests the case that an instance that was previously removed from
the cluster is able to be successfully added back.

(cherry picked from commit 3985691)
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@mansikulkarni96
Copy link
Member

/test aws-e2e-operator

@mansikulkarni96
Copy link
Member

/retest

Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@mansikulkarni96
Copy link
Member

/retest

@mansikulkarni96
Copy link
Member

/refresh

@mansikulkarni96
Copy link
Member

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9bd9327 into openshift:release-4.8 Aug 18, 2021
mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
…penshift-cherrypick-robot/cherry-pick-574-to-release-4.8

Updated upstream source commit.
Commit details follow:

Project: https://github.com/openshift/windows-machine-config-operator.git
Branch:  release-4.8
Commit:  9bd9327
Author:  OpenShift Merge Robot
Date:    Wed, 18 Aug 2021 15:06:19 -0400

    Merge pull request openshift#610 from openshift-cherrypick-robot/cherry-pick-574-to-release-4.8

    [release-4.8] WINC-648: [wmco] Remove HNS networks in BYOH deconfiguration

Additional included commits:
  a7b2941, b4378cd, 08595bc, 156e2d1, b23bb4a, ddb186b

automerge: yes
x-md5: 2280bdacd8014362a1c9816086f62d00
Change-Id: I878d3100de19b7198a68292d17eb225c7d632674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants