Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1995611: [wmco] Capture delete event for BYOH Windows nodes #617

Merged
merged 2 commits into from Aug 19, 2021
Merged

[release-4.8] Bug 1995611: [wmco] Capture delete event for BYOH Windows nodes #617

merged 2 commits into from Aug 19, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #602

/assign mansikulkarni96

@mansikulkarni96
Add a helper function isValidWindowsNode
4a7372f 
This commit adds a helper function isValidWindowsNode
to filter out the nodes based on the BYOH and
Windows labels present.
@mansikulkarni96
Capture delete event for BYOH Windows nodes
751691a 
This commit edits the windowsNodePredicate used in the
configmap controller to capture delete events for nodes
which have OS label Windows and BYOH label set.
Fixes BZ#1992428
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 19, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@openshift-cherrypick-robot: Bugzilla bug 1992428 has been cloned as Bugzilla bug 1995611. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1995611: [wmco] Capture delete event for BYOH Windows nodes

In response to this:

[release-4.8] Bug 1992428: [wmco] Capture delete event for BYOH Windows nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1992428: [wmco] Capture delete event for BYOH Windows nodes [release-4.8] Bug 1995611: [wmco] Capture delete event for BYOH Windows nodes Aug 19, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1995611, which is invalid:

  • expected dependent Bugzilla bug 1992428 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1995611: [wmco] Capture delete event for BYOH Windows nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
@mansikulkarni96
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@mansikulkarni96: This pull request references Bugzilla bug 1995611, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1992428 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1992428 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 19, 2021
@openshift-ci openshift-ci bot requested a review from sgaoshang August 19, 2021 14:31
@aravindhp
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mansikulkarni96
Copy link
Member

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5596c35 into openshift:release-4.8 Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1995611 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1995611: [wmco] Capture delete event for BYOH Windows nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp Awaiting requested review from aravindhp

@sebsoto sebsoto Awaiting requested review from sebsoto

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @mansikulkarni96 @aravindhp @openshift-bot @openshift-merge-robot