-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINC-667: [release-4.8] [vendor] Bump OpensShift dependencies to latest #629
WINC-667: [release-4.8] [vendor] Bump OpensShift dependencies to latest #629
Conversation
This commit bumps OpenShift depedencies to latest release-4.8 commits. Bumped github.com/openshift/api, github.com/openshift/library-go and github.com/openshift/machine-api-operator. Ran `go mod tidy && go mod vendor && go mod verify` This commit also fixes 'make build' by changing azureprovider.ManagedDisk -> azureprovider.ManagedDiskParameters in test/e2e/providers/azure/azure.go
@mansikulkarni96: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mansikulkarni96: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mansikulkarni96: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @mansikulkarni96
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
/cherry-pick community-4.8 |
@alinaryan: #629 failed to apply on top of branch "community-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR bumps OpenShift depedencies to latest
release-4.8 commits.
Bumped github.com/openshift/api, github.com/openshift/library-go
and github.com/openshift/machine-api-operator.
Ran
go mod tidy && go mod vendor && go mod verify
This commit also fixes
make build
by changingazureprovider.ManagedDisk -> azureprovider.ManagedDiskParameters
in test/e2e/providers/azure/azure.go