[release-4.8] WINC-645: [controllers] Handle generic events #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify the check for a Windows node - Update all controllers to handle generic events
|
Does this need to be in for 3.1.0? |
I am fine holding off on this given it is not a bug fix. Though I am a bit worried that we would miss events. |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mansikulkarni96
pushed a commit
to mansikulkarni96/windows-machine-config-operator
that referenced
this pull request
Aug 7, 2023
…penshift-cherrypick-robot/cherry-pick-628-to-release-4.8 Updated upstream source commit. Commit details follow: Project: https://github.com/openshift/windows-machine-config-operator.git Branch: release-4.8 Commit: 05d607c Author: OpenShift Merge Robot Date: Tue, 24 Aug 2021 21:17:14 -0400 Merge pull request openshift#634 from openshift-cherrypick-robot/cherry-pick-628-to-release-4.8 [release-4.8] WINC-645: [controllers] Handle generic events automerge: yes x-md5: 5bf414abbd4aa0932d9ff80cb45181ba Change-Id: I70b27f1158cc8905c8b1d6f19745845349c49c97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #628
/assign aravindhp