Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] WINC-668: [test] Replace deprecated node label selector #643

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #636

/assign mansikulkarni96

This commit replaces the deprecated kubernetes node selector
"beta.kubernetes.io/os" with "kubernetes.io/os" in the e2e
network tests.
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit b888cec into openshift:release-4.8 Aug 26, 2021
mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
…penshift-cherrypick-robot/cherry-pick-636-to-release-4.8

Updated upstream source commit.
Commit details follow:

Project: https://github.com/openshift/windows-machine-config-operator.git
Branch:  release-4.8
Commit:  b888cec
Author:  OpenShift Merge Robot
Date:    Thu, 26 Aug 2021 12:13:45 -0400

    Merge pull request openshift#643 from openshift-cherrypick-robot/cherry-pick-636-to-release-4.8

    [release-4.8] WINC-668: [test] Replace deprecated node label selector

Additional included commit: 9fd55c4

automerge: yes
x-md5: 7ab57b230e7ccebe21170fc582167ba8
Change-Id: Id869df4b048baa663c35e4438f386a21a250f5a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants