Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address #657

Merged
merged 2 commits into from Sep 3, 2021
Merged

[release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address #657

merged 2 commits into from Sep 3, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #655

/assign mansikulkarni96

@saifshaikh48
Introduce nodeutil package
5256e7b 
This commit renames the findNode method to findByAddress and moves it to a
newly created node utility package.
@saifshaikh48
Perform DNS lookup on instance address
f197695 
This commit performs checks on a Windows instance's network address.
Instead of using the raw address, it is checked to ensure it is an IPv4
address or if it resolves via DNS lookup. This is needed in case an instance's
DNS address does not match its hostname.

Fixes BZ#1995684
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 2, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@openshift-cherrypick-robot: Bugzilla bug 1995684 has been cloned as Bugzilla bug 2000787. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address

In response to this:

[release-4.8] Bug 1995684: Validate and perform DNS lookup on Windows instance network address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1995684: Validate and perform DNS lookup on Windows instance network address [release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address Sep 2, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2000787, which is invalid:

  • expected dependent Bugzilla bug 1995684 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 2, 2021
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@sebsoto
Copy link
Contributor

sebsoto commented Sep 3, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mansikulkarni96
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

@mansikulkarni96: This pull request references Bugzilla bug 2000787, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1995684 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1995684 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit f2277c0 into openshift:release-4.8 Sep 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2000787 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
@cp-paas-bot
Updated US source to: f2277c0 Merge pull request openshift#657 from o…
cf65bb2 
…penshift-cherrypick-robot/cherry-pick-655-to-release-4.8

Updated upstream source commit.
Commit details follow:

Project: https://github.com/openshift/windows-machine-config-operator.git
Branch:  release-4.8
Commit:  f2277c0
Author:  OpenShift Merge Robot
Date:    Fri, 3 Sep 2021 21:40:55 +0200

    Merge pull request openshift#657 from openshift-cherrypick-robot/cherry-pick-655-to-release-4.8

    [release-4.8] Bug 2000787: Validate and perform DNS lookup on Windows instance network address

Additional included commits: 5256e7b, f197695

Referenced RedHat BugZilla bug: BZ#1995684

automerge: yes
x-md5: cb78b8c31d74f4bdc71cf35e5b6e7d88
Change-Id: I0f027edce51ebe736385c0849aec6e15a6df0c73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp Awaiting requested review from aravindhp

@sebsoto sebsoto Awaiting requested review from sebsoto

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @mansikulkarni96 @sebsoto @openshift-bot @openshift-merge-robot @saifshaikh48