Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-672: [build] Add containerd components #696

Merged
merged 4 commits into from Sep 22, 2021
Merged

WINC-672: [build] Add containerd components #696

merged 4 commits into from Sep 22, 2021

Conversation

aravindhp
Copy link
Contributor

  • [submodules] Add containerd
  • [submodules] Add hcsshim
  • [build] Add containerd components

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@openshift-ci openshift-ci bot requested a review from sebsoto September 21, 2021 21:48
@aravindhp
Copy link
Contributor Author

/approve cancel
/cc @openshift/openshift-team-windows-containers

@openshift-ci openshift-ci bot requested a review from a team September 21, 2021 21:50
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@aravindhp
[submodules] Add containerd
6cd8207 
Ran:
git submodule add https://github.com/openshift/containerd
cd containerd/
git checkout release/1.5
@aravindhp
[submodules] Add hcsshim
5fc8225 
Ran:
git submodule add https://github.com/openshift/hcsshim
cd hcsshim
git checkout v0.9.0-rc0
selansen
selansen reviewed Sep 22, 2021
View reviewed changes
.gitmodules Show resolved Hide resolved
@selansen
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
saifshaikh48
saifshaikh48 reviewed Sep 22, 2021
View reviewed changes
.gitmodules Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@sebsoto
Copy link
Contributor

sebsoto commented Sep 22, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@saifshaikh48
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@aravindhp
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@aravindhp: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

mansikulkarni96
mansikulkarni96 reviewed Sep 22, 2021
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
@aravindhp
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
@aravindhp
[build] Add containerd components
a61d3e4 
Build and add containerd components (containerd.exe and
containerd-shim-runhcs-v1.exe) to the payload.
@aravindhp
[hack] Make lint ignore containerd and hcsshim
82eec62
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@mansikulkarni96
Copy link
Member

/lgtm

@aravindhp
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ca79648 into openshift:master Sep 22, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2021
Merged
@openshift-cherrypick-robot
Copy link

@aravindhp: new pull request created: #701

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp aravindhp deleted the WINC-672-containerd branch October 1, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selansen selansen selansen left review comments

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@mansikulkarni96 mansikulkarni96 mansikulkarni96 left review comments

@jrvaldes jrvaldes jrvaldes left review comments

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@selansen selansen

@saifshaikh48 saifshaikh48

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@aravindhp @selansen @sebsoto @saifshaikh48 @openshift-cherrypick-robot @openshift-bot @mansikulkarni96 @jrvaldes @openshift-merge-robot