Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update SAM verbiage in project volume doc #798

Merged

Conversation

aravindhp
Copy link
Contributor

@aravindhp
Copy link
Contributor Author

/cc @openshift/openshift-team-windows-containers @codyhoag

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@aravindhp
Copy link
Contributor Author

/approve cancel

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
docs/projected-volume.md Outdated Show resolved Hide resolved
containers are designed to run the user mode portion of the OS in isolation from the host, hence the maintenance of a
virtual SAM database. As a result, the kublet running on the host does not have the ability to dynamically configure
host file ownership for virtualized container accounts. It is recommended that if files on the host machine are to be
shared with the container then they should be placed into their own volume mount outside of `C:\`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this implying that there should be a separate letter drive for each set of host files needed to be shared with different containers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it. This is coming directly from Microsoft.

Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple wording nits from my side; LGTM otherwise

Comment on lines +9 to +10
user and group accounts in a database file called Security Account Manager (SAM). Each container maintains its own
instance of the SAM database, to which the host has no visibility into while the container is running. Windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user and group accounts in a database file called Security Account Manager (SAM). Each container maintains its own
instance of the SAM database, to which the host has no visibility into while the container is running. Windows
user and group accounts in a database file called Security Account Manager (SAM). Each container maintains its own
instance of the SAM database; the host machine has no visibility into the SAM database while the container is running. Windows

This sentence sounded awkward to me. Does this suggestion mean the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could imply the SAM database on the host. So it would be safer to leave this as is.

docs/projected-volume.md Outdated Show resolved Hide resolved
@selansen
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@codyhoag
Copy link
Contributor

LGTM

@sebsoto
Copy link
Contributor

sebsoto commented Nov 19, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit cfa5eeb into openshift:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants