Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] WINC-678: Upgrade to Operator SDK 1.15.0 #839

Merged
merged 7 commits into from Jan 12, 2022
Merged

[release-4.8] WINC-678: Upgrade to Operator SDK 1.15.0 #839

merged 7 commits into from Jan 12, 2022

Conversation

alinaryan
Copy link
Contributor

This PR updates Operator SDK in WMCO from v1.6.1 to latest v1.15.0.

Followed upgrade steps from https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.15.0/

Manual cherry pick of #794

@alinaryan
[build] update Makefile targets
7698427 
This commit removes CRD_OPTIONS as a Makefile target since the v1beta1 K8s APIs
are no longer supported in Kubernetes 1.22+.

(cherry picked from commit 13e84f8)
@alinaryan
[config] Move leases to its own proxy-role rule
e5129c7 
This commmit bumps leases.coordination.k8s.io to its own proxy-role
rule.

(cherry picked from commit 15e2824)
@alinaryan
[config] Add containerPort protocol
99688a4 
This commit specifies the containerPort protocol field in manifest files.

(cherry picked from commit 353cf52)
@alinaryan
[deploy] Update bundle directory
95ae59d 
Ran 'make bundle' to reflect the config changes.
Manually removed ':latest' in image to maintain
CI compatibility.

(cherry picked from commit d78647f)
@alinaryan
[docs] Update docs for OSDK 1.15.0
aade5ee 
Update docs/HACKING.md

(cherry picked from commit 7459a10)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021 •
edited

@alinaryan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] WINC-678: Upgrade to Operator SDK 1.15.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alinaryan
[hack] Update OSDK bin location in common.sh
8b1c1f7 
This updates the OSDK bin location tag from 1.6.1 to latest 1.15.0 in
common.sh to test OSDKs usage in our e2e tests.

(cherry picked from commit c778241)
@saifshaikh48 saifshaikh48 mentioned this pull request Dec 1, 2021
Merged
@alinaryan
[vendor] update sigs.k8s.io/controller-runtime
813d431 
Ran:
go get sigs.k8s.io/controller-runtime

Ran:
go mod tidy && go mod vendor && go mod verify

Ran:
make manifests
make build
@saifshaikh48
Copy link
Contributor

/hold

code freeze until 3.1.1 ships

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

@alinaryan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test aws-e2e-operator
  • /test aws-e2e-upgrade
  • /test azure-e2e-operator
  • /test build
  • /test ci-index
  • /test images
  • /test lint
  • /test platform-none-vsphere-e2e-operator
  • /test unit
  • /test vsphere-e2e-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-windows-machine-config-operator-release-4.8-aws-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-aws-e2e-upgrade
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-azure-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-build
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-ci-index
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-images
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-lint
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-unit
  • pull-ci-openshift-windows-machine-config-operator-release-4.8-vsphere-e2e-operator

In response to this:

/test ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alinaryan
Copy link
Contributor Author

/test images

@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@selansen
Copy link
Contributor

/lgtm

@sebsoto
Copy link
Contributor

sebsoto commented Jan 12, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alinaryan, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@saifshaikh48
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@selansen
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 73b10b4 into openshift:release-4.8 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@selansen selansen

@jrvaldes jrvaldes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alinaryan @saifshaikh48 @jrvaldes @selansen @sebsoto @openshift-merge-robot