Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Disable Pod DNS Resolution Test #884

Merged
merged 1 commit into from Feb 1, 2022

Conversation

selansen
Copy link
Contributor

@selansen selansen commented Jan 28, 2022

This test has 25% failure rate in CIs. WINC-743 has been created to address
this issue. Until we address WINC-743, this test has been temporarily
disabled.

Signed-off-by: selansen esiva@redhat.com

@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
// This test has 25% failure rate in CI. WINC-743 has been created to address
// this issue. Until we address WINC-743, this test has been temporarily
// disabled.
t.Skip("Pod DNS Resolution testing is disabled")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Pod DNS resolution is disabled pending flake investigation? Otherwise we are just stating the obvious and a t.Skip() would suffice.

This test has 25% failure rate in CIs. WINC-743 has been created to address
this issue. Until we address WINC-743, this test has been temporarily
 disabled.

Signed-off-by: selansen <esiva@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@sebsoto
Copy link
Contributor

sebsoto commented Jan 31, 2022

/approve

@selansen
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

@selansen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ce2d16c into openshift:master Feb 1, 2022
@selansen
Copy link
Contributor Author

selansen commented Feb 1, 2022

/cherry-pick release-4.10

@selansen
Copy link
Contributor Author

selansen commented Feb 1, 2022

/cherry-pick release-4.9

@selansen
Copy link
Contributor Author

selansen commented Feb 1, 2022

/cherry-pick release-4.8

@selansen
Copy link
Contributor Author

selansen commented Feb 1, 2022

/cherry-pick community-4.9

@selansen
Copy link
Contributor Author

selansen commented Feb 1, 2022

/cherry-pick community-4.8

@openshift-cherrypick-robot

@selansen: new pull request created: #886

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@selansen: new pull request created: #887

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@selansen: #884 failed to apply on top of branch "release-4.8":

Applying: Disable Pod DNS Resolution Test
Using index info to reconstruct a base tree...
M	test/e2e/network_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/network_test.go
CONFLICT (content): Merge conflict in test/e2e/network_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Disable Pod DNS Resolution Test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@selansen: new pull request created: #888

In response to this:

/cherry-pick community-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@selansen: new pull request created: #889

In response to this:

/cherry-pick community-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Contributor

jrvaldes commented Mar 9, 2022

/cherry-pick release-4.8

@openshift-cherrypick-robot

@jrvaldes: new pull request created: #970

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants