New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.8] WINC-607: Add support for platform=none in e2e test suite (Cont.) #941
[release-4.8] WINC-607: Add support for platform=none in e2e test suite (Cont.) #941
Conversation
- Disable the application ingress load balancer test for platform=none - Use t.Skipf() to ignore the test with better logging - Move the check to the beginning of the test to avoid the creation of the WindowsWebServer deployment Follow-up to 91ecc9d
This commit skips the MachineSet update in the Windows node deletion test if no MachineSet is found with the Windows label. This is a corner case for platform-agnostic infrastructure and e2e tests executions where no instances are configured via MachineController, for example: `hack/run-ci-e2e-test.sh -m 0`.
`jq` is needed in e2e test script to count the number of data items in the windows-instances ConfigMap.
/retest |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sebsoto, selansen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #896
/assign jrvaldes