Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] WINC-607: [e2e] Modularize BYOH configuration test #969

Merged
merged 1 commit into from Mar 10, 2022
Merged

[release-4.8] WINC-607: [e2e] Modularize BYOH configuration test #969

merged 1 commit into from Mar 10, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #865

/assign mansikulkarni96

@jrvaldes
Modularize BYOH configuration test
ecc1fa9 
This commit modularizes the testBYOHConfiguration test, so that
it is easy to maintain and can be extended. This is a pre-work
to introduce support for platform=none.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 9, 2022
Merged
@openshift-ci openshift-ci bot requested review from sebsoto and selansen March 9, 2022 04:01
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@sebsoto
Copy link
Contributor

sebsoto commented Mar 9, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@jrvaldes
Copy link
Contributor

jrvaldes commented Mar 9, 2022

/hold

for #970 to disable DNS test

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@mansikulkarni96
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@mansikulkarni96
Copy link
Member

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@selansen
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sebsoto, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ec07de3 into openshift:release-4.8 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsoto sebsoto Awaiting requested review from sebsoto

@selansen selansen Awaiting requested review from selansen

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @mansikulkarni96 @sebsoto @jrvaldes @openshift-bot @selansen @openshift-merge-robot