Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] WINC-607: Add support for platform=none in e2e test suite #973

Conversation

mansikulkarni96
Copy link
Member

Manual backport of #858 to fix the location of openshift/mapi api used in all branches before release-4.10.

jrvaldes and others added 4 commits March 9, 2022 23:53
- Add platform=none as new cloud provider in WMCO e2e test suite
- Add a check in ConfigMap controller test to avoid the creation of
  Windows instances via machineSet for platform-agnostic infrastructure
- Introduce a function to validate windows-instances ConfigMap
- Add a new step in run-ci-e2e-test.sh script to create the windows-instances
  configMap once the operator deployment process is complete.
- Add a new Makefile target to test BYOH in platform=none, where the number of
  Windows instances created by MachineSet is fixed to 0.

(cherry picked from commit c1fb113)
This commit updates the mapi api used in the none.go file
from github.com/openshift/api/machine/v1beta1 to
github.com/openshift/machine-api-operator/pkg/apis/machine/v1beta1
complying with the location of api for the release-4.8 branch.
This commit adds section in HACKING.md to describe the process
of running the e2e tests on a platform-agnostic infrastructure.

(cherry picked from commit cfdded1)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@mansikulkarni96: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] WINC-607: Add support for platform=none in e2e test suite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from sebsoto and selansen March 10, 2022 05:02
@saifshaikh48
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@jrvaldes
Copy link
Contributor

/test aws-e2e-upgrade

@jrvaldes
Copy link
Contributor

/lgtm

@selansen
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mansikulkarni96, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@mansikulkarni96: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5ea7e8c into openshift:release-4.8 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants