Delete unused templates #1245
Merged
Delete unused templates #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's ready for review but please coordinate with @pbergene on merging it. |
chmouel
approved these changes
Apr 10, 2019
joshuawilson
approved these changes
Apr 10, 2019
|
Ack. Let's close off the tenant side and then proceed to scale down the control plane deployments once we're clear there. At that point we can remove these entries so that saas-herder doesn't do any re-deploys - and once we validate that we can remove the actual jobs. |
ibuziuk
approved these changes
Apr 15, 2019
|
The rh-che test against prod-preview failed. Please review the job results and re-run the job by commenting [test] if necessary. |
|
The rh-che test against prod-preview failed. Please review the job results and re-run the job by commenting [test] if necessary. |
riuvshin
approved these changes
Apr 18, 2019
|
as @pbergene mentioned it is safe to remove these entries to make sure it is not redeployed by saasherder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of openshift.io -> che.openshift.io transition.