Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bme280 humidity #1231

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

NonPIayerCharacter
Copy link
Contributor

Measurement code copied from esphome.
Don't have a bme280, but bmp280 continue to work normally.
Can try to add bme680, but it is significantly different from bmx280, so the code here will not work.
So if i'm to try, am i to code it in this library, or add a new one instead?

@openshwprojects
Copy link
Owner

Very good, thank you! I don't have this chip as well but maybe @divadiow has?

Regarding 680 - well, if you say it's different, then create a separate driver, you know, separate entry in drv_main.c, then a file drv_bme680, etc. You can also ask me for help anytime and I will try my best. Just make sure to put your driver disabled by default because we are trying to avoid reaching max OTA size on some platforms

@divadiow
Copy link
Contributor

only BME680/BMP280 currently. will buy BME280

@openshwprojects
Copy link
Owner

What is the state of this feature? Has it been already tested? I would like to merge it but i dont have required chip at hand

@divadiow
Copy link
Contributor

if it's any help, my BME280 should arrive this week

@divadiow
Copy link
Contributor

divadiow commented Jun 9, 2024

image

Address 0x76 (dec 118)

BME280

@openshwprojects
Copy link
Owner

Thank you, I think I can merge it now

@openshwprojects openshwprojects self-requested a review June 9, 2024 17:02
@openshwprojects openshwprojects merged commit 9c58f9d into openshwprojects:main Jun 9, 2024
9 checks passed
Copy link

github-actions bot commented Jun 9, 2024

🎉 This PR is included in version 1.17.610 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@DeDaMrAzR
Copy link
Contributor

DeDaMrAzR commented Jun 10, 2024

to initiate and read BME280 use the following in your autoexec file:

// startDriver BMP280 [ClkPin] [DatPin] [OptionalTargetChannel]
startDriver BMP280 7 8 2
BMP280_Adr 0x76

1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants