-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bme280 humidity #1231
Add bme280 humidity #1231
Conversation
Very good, thank you! I don't have this chip as well but maybe @divadiow has? Regarding 680 - well, if you say it's different, then create a separate driver, you know, separate entry in drv_main.c, then a file drv_bme680, etc. You can also ask me for help anytime and I will try my best. Just make sure to put your driver disabled by default because we are trying to avoid reaching max OTA size on some platforms |
only BME680/BMP280 currently. will buy BME280 |
What is the state of this feature? Has it been already tested? I would like to merge it but i dont have required chip at hand |
if it's any help, my BME280 should arrive this week |
Thank you, I think I can merge it now |
🎉 This PR is included in version 1.17.610 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Measurement code copied from esphome.
Don't have a bme280, but bmp280 continue to work normally.
Can try to add bme680, but it is significantly different from bmx280, so the code here will not work.
So if i'm to try, am i to code it in this library, or add a new one instead?