Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeAssistant / Discovery / Add sensor units #327

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

iprak
Copy link
Contributor

@iprak iprak commented Oct 23, 2022

  • Added separate const for mqtt sensor class and units.
  • Added missing units for voltage, current and power.
  • Also added Wh unit for energy when device_class is not None.

#322

@iprak
Copy link
Contributor Author

iprak commented Oct 23, 2022

@openshwprojects new_mqtt_deduper.c is causing build failures

../shared/src/user_main.o: In function `Main_OnEverySecond':
/home/runner/work/OpenBK7231T_App/OpenBK7231T_App/sdk/OpenXR809/project/oxr_sharedApp/gcc/../shared/src/user_main.c:204: undefined reference to `MQTT_Dedup_Tick'
collect2: error: ld returned 1 exit status
make[2]: *** [../../../project/project.mk:204: oxr_sharedApp.axf] Error 1
make[2]: Leaving directory '/home/runner/work/OpenBK7231T_App/OpenBK7231T_App/sdk/OpenXR809/project/oxr_sharedApp/gcc'
make[1]: Leaving directory '/home/runner/work/OpenBK7231T_App/OpenBK7231T_App'
make[1]: *** [Makefile:95: build-XR809] Error 2
make: *** [Makefile:90: OpenXR809] Error 2
Error: Process completed with exit code 2.
./bin/build/w800/lib/libuser.a(cmd_newLEDDriver.o): In function `sendColorChange.part.1':
(.text.sendColorChange.part.1+0x50): undefined reference to `MQTT_PublishMain_StringString_DeDuped'
./bin/build/w800/lib/libuser.a(cmd_newLEDDriver.o): In function `sendColorChange.part.1':
(.text.sendColorChange.part.1+0x50): relocation truncated to fit: R_CKCORE_PCREL_IMM26BY2 against undefined symbol `MQTT_PublishMain_StringString_DeDuped'
collect2: error: ld returned 1 exit status
make[1]: *** [tools/w800/rules.mk:169: bin/build/w800/image/w800.elf] Error 1
make[1]: Leaving directory '/home/runner/work/OpenBK7231T_App/OpenBK7231T_App/sdk/OpenW800'
make: *** [Makefile:121: OpenW800] Error 2
Error: Process completed with exit code 2.

@openshwprojects
Copy link
Owner

@iprak just missing from makefile on those platforms, I will fix it tomorrow, or you can do it earlier.

@iprak
Copy link
Contributor Author

iprak commented Oct 23, 2022

@openshwprojects
Copy link
Owner

Thank you! I just woke up and started working on OBK. Your support is very valuable. I am releasing the online devices list, see main readme on our main page for details.

Merging this now.

@openshwprojects openshwprojects merged commit 9447dd6 into openshwprojects:main Oct 24, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.14.50 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@iprak iprak deleted the add-sensor-units branch November 1, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants