Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C3DFileAdapter::read() assumes time starts at 0. #1732

Closed
chrisdembia opened this issue May 25, 2017 · 3 comments
Closed

C3DFileAdapter::read() assumes time starts at 0. #1732

chrisdembia opened this issue May 25, 2017 · 3 comments
Labels
Documentation
Milestone
Future Release

Comments

@chrisdembia
Copy link
Member

Based on discussion with @jimmyDunne, this assumption might be reasonable, in which we could just document this behavior.
@jenhicks jenhicks added this to the 4.0 Documentation milestone Jun 1, 2017
@tkuchida
Copy link
Member

tkuchida commented Jun 3, 2017

See comments in C3DFileAdapter.cpp, L121 and L243.

@chrisdembia
Copy link
Member Author

I think it would be good to additionally provide user-facing documentation, perhaps in the class description for C3DFileAdapter.

@tkuchida
Copy link
Member

tkuchida commented Jun 3, 2017

I think it would be good to additionally provide user-facing documentation, perhaps in the class description for C3DFileAdapter.

I agree; I was not advocating against that. The comments on these lines should be updated if a design decision has been made about start time.

@jenhicks jenhicks closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
Future Release
Development

No branches or pull requests
3 participants
@chrisdembia @tkuchida @jenhicks