Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thelen2003Muscle equilibrium solve failure #2686

Closed
aseth1 opened this issue Mar 8, 2020 · 3 comments
Closed

Thelen2003Muscle equilibrium solve failure #2686

aseth1 opened this issue Mar 8, 2020 · 3 comments
Labels

Comments

@aseth1
Copy link
Member

aseth1 commented Mar 8, 2020

@chrisdembia reported during a developer meeting that Scott Uhlrich encountered this failure only for specific model and state values affecting a single muscle. The failure can be reproduced but it is not clear why the algorithm fails to find an equilibrium since it does not appear to be a singularity in fiber or tendon force production. The Newton solve fails to find appropriate step size and fails due to exceeding the iteration limit. A test case is being added.

@jenhicks
Copy link
Member

@aseth1 @mjhmilla OK to close?

@mjhmilla
Copy link
Contributor

Actually I think this one should remain open. Here's why:

Problem: Several muscle models have the possibility of failing to initialize correctly.

Solution Steps:

  1. [Done] Build a general purpose initialization test that can catch all of the various ways a model can fail to initialize. This has been done and the code is currently sitting in the branch feature_equilibrium.
  2. [Open] Fix the initialization methods for the models that have initialization problems.

I have a straight forward fix (remove all Newton methods and replace with bisection + initialize the model so that the tendon is static). I simply haven't gotten to this yet. If there is a date when you'd like to see part 2 completed please let me know.

@jenhicks
Copy link
Member

Closing as the (important) remaining issues are covered elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants