Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow C3DFileAdpaterReading issue #1698 #1730

Merged
merged 10 commits into from
May 25, 2017
Merged

Fix slow C3DFileAdpaterReading issue #1698 #1730

merged 10 commits into from
May 25, 2017

Commits on May 25, 2017

  1. Added timing to C3DFileAdapter testing

    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    46385eb View commit details
    Browse the repository at this point in the history

  2. Add a protected convenience constructor to create a DataTable with th… 

    …e data and labels supplied.

Derived classes can use this to avoid appendRow(), which resized the internal matrix.
    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    9b827ad View commit details
    Browse the repository at this point in the history

  3. Provide a convenience constructor for TimeSeriesTable_ to be filled f… 

    …rom already populated time vector and data matrix.
    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    3acb82c View commit details
    Browse the repository at this point in the history

  4. Speedup C3DFileAdapter::extendRead() by exploiting the new TimeSeries… 

    …Table constructor and populating a pre-allocated SimTK::Matrix without resizing.
    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    a1ee753 View commit details
    Browse the repository at this point in the history

  5. To access member of template class need to disambiguate with this->

    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    eb4136d View commit details
    Browse the repository at this point in the history

  6. Fix typo and clarify comment.

    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    b99762f View commit details
    Browse the repository at this point in the history

  7. Add more details about why derive class implementations of the conven… 

    …ience constructor must perform their own validation because virtual validateRow() will not invoke the derived class override during construction.

Also do not exceed 80chars.
    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    eb0ed3c View commit details
    Browse the repository at this point in the history

  8. Address size_t->int warning and clarify comments.

    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    eff1881 View commit details
    Browse the repository at this point in the history

  9. Make nf an int and use marker_nrow for number of marker frames.

    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    3e5b56a View commit details
    Browse the repository at this point in the history

  10. Address size_t -> int loss warning.

    Ajay Seth committed May 25, 2017
    Configuration menu
    Copy the full SHA
    26b8135 View commit details
    Browse the repository at this point in the history