-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Do Not Merge: Quick and dirty way to get and return GravityForce from model #3416
base: main
Are you sure you want to change the base?
Conversation
Here is a personal comment about this PR. I think this is exactly what I need but I can't manage to test it, trying to compil this change fails. Where I am now:
|
Would someone please help me compile Opensim's Python bindings ? Unfortunately, #PR3414 was closed yesterday, this was an alternative way to solve the problem described in https://simtk.org/plugins/phpBB/viewtopic.php?f=91&t=15254&sid=e4de93b208ba09734d13954a9cb03480... Retrieving gravity forces through Opensim's python bindings is an essential part of my current work, but I was not able to correctly compile a swig-python module or recompile python binding because Windows compilation process is really a mess. Yet all the necessary code seems to be available... Thanks in advance ! |
The PR has been updated without the need for a separate plugin, please follow the notes and check the diffs on the PR |
I tried to test this PR, but I lack skills and practice in CMake/Visual Studio to build an runable version of this PR.
|
Hello,
I took a look at your log files and the build problem with spdlog is due to
using an early version of visualStudio that fails to compile the most
recent version of this library. Can you upgrade to VisualStudio 2022 and
retry.
Please let me know if you have any questions,
-Ayman
…On Mon, Jun 5, 2023 at 6:23 AM jsn-inrs ***@***.***> wrote:
I tried to test this PR, but I lack skills and practice in CMake/Visual
Studio to build an runable version of this PR.
The attached zip file includes :
- the "Build_and_Test_Method.txt" file explaining how I tried to build
the code
- attached files described in the former file.
The compilation fails. Would someone "take me by the hand" as a total
newbie to help me retrieve gravity data ?
Thanks in advance !
MAJ-osim45-fromScratch.zip
<https://github.com/opensim-org/opensim-core/files/11652939/MAJ-osim45-fromScratch.zip>
—
Reply to this email directly, view it on GitHub
<#3416 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6JY4BFA6BSWV6MHATZ2RTXJXMVJANCNFSM6AAAAAAVMTCXXM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thank you very much for the attention given to this PR. Please attached find a zip archive with logs about today's build trials. spdlog compiles and installs fine with VS2019 and VS2022. However, I can't compile simbody37 with those framework, and opensim's documentation states that the same compiler should be used for all elements of the process (spdlog, simbody37 and opensim) (?) so I feel quite desoriented... |
Hello, sorry I couldn't understand the error (excuse my bad french) but the integrated build ci runs regularly with vs2022 without an issue e.g. https://pipelines.actions.githubusercontent.com/serviceHosts/5b528c53-c39b-437a-bbf8-bd04c2465622/_apis/pipelines/1/runs/76/signedlogcontent/2?urlExpires=2023-06-14T18%3A18%3A18.2466870Z&urlSigningMethod=HMACV1&urlSignature=n%2BnPEPOnbGXC%2BU6zO9HjCD23%2F9r7ujCMKMWDI4HX%2FtM%3D |
Yes !! You did it ! Don't apologize for your bad french, it's only about Visual Studio mysteries... Well, I've downloaded this artifact (I didn't even know such thing existed) and installed it very easily. Thanks A LOT for your help and availability. Unfortunately, I don't understand what was wrong in building OpenSim on my own (M$ mysteries or my own lack of skills, surely both). |
@aymanhab, can we close this? |
This method and a couple other methods required by other users need to be added to Model then we can close this. |
Fixed by PR #3618 |
@jsn-inrs the change was incoroprated into OpenSim::Model and will be included in the next release, you can check the artifacts to adjust accordingly. Thanks for your patience |
Fixes issue #<issue_number>
Brief summary of changes
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)