Implement delayed actions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 96.03% 95.88% -0.15%
==========================================
Files 7 7
Lines 857 875 +18
Branches 121 124 +3
==========================================
+ Hits 823 839 +16
- Misses 25 26 +1
- Partials 9 10 +1
Continue to review full report at Codecov.
|
|
Very nice code. Feel free to merge it into master @Peque ! 👍 |
Flood1993
reviewed
Mar 9, 2017
| action(*args) | ||
|
|
||
| Thread(target=wait).start() | ||
| event.stop = event.set |
There was a problem hiding this comment.
I'm not sure what it does... Could you explain?
There was a problem hiding this comment.
That line simply allows you to use timer.stop instead of timer.set, which I think is more intuitive.
Flood1993
approved these changes
Mar 9, 2017
| action(*args) | ||
|
|
||
| Thread(target=wait).start() | ||
| event.stop = event.set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A self-contained change that could be added to master while we keep making other changes.