Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup alerts for broken data pipelines #1070

Closed
ravenac95 opened this issue Mar 19, 2024 · 2 comments · Fixed by #1776
Closed

Setup alerts for broken data pipelines #1070

ravenac95 opened this issue Mar 19, 2024 · 2 comments · Fixed by #1776
Assignees
Labels
c:data Gathering data (e.g. indexing) P0 Highest priority issue

Comments

@ravenac95
Copy link
Member

Describe the feature you'd like to request

We currently don't have any alerts for any of our pipelines failing other than manually checking right now. We should have automated checks for ourselves.

Describe the solution you'd like

Some kind of automated check messages us either on discord or some other method.

Describe alternatives you've considered

N/A

@ravenac95 ravenac95 added the c:data Gathering data (e.g. indexing) label Mar 19, 2024
@ryscheng ryscheng added this to the Infra: Data warehouse milestone Mar 26, 2024
@ryscheng
Copy link
Member

Dagster+ solution
https://docs.dagster.io/dagster-plus/managing-deployments/alerts#dagster-alerts

Or the cheap version is to periodically scan Dagster API for failures, then throw that into a Discord comment

@ryscheng ryscheng self-assigned this May 21, 2024
@ryscheng ryscheng added the P0 Highest priority issue label May 21, 2024
@ravenac95
Copy link
Member Author

ravenac95 commented May 21, 2024

We can also think about doing things like mentioned here: dagster-io/dagster#19944

My thought would be something like this but it would send a message to our discord.

In order to have that setup we'd need to connect the secret to our dagster deployment. I would then pull that secret directly from the python code (perhaps we have an environment variable to reference it's location). Otherwise we can use the already provided secret resovler: https://github.com/doitintl/kube-secrets-init that is a side car to our applications. However, I think it would be better to have our dagster hand written components use the secret manager directly as opposed to relying on the side car. It just exposes less secrets in the environment directly. So you can't accidentally run env and log secrets by accident.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:data Gathering data (e.g. indexing) P0 Highest priority issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants