Update givestation.yaml #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBloomguy
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
ccerv1
requested changes
May 23, 2024
There was a problem hiding this comment.
Thank you!
Two things:
- there is an extra space before
name: CrowdFunding - Can you add the deployer address for the CrowdFunding contract? I believe it should be: 0xabF763013d5B2dEfcB7BEaD1342962b24828C7Cf. If you add the address, as well as all networks it had deployed a contract on, then we can automatically index any of its contracts (on any chain) going forward.
Thanks again!
MrBloomguy
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
|
The yaml has been updated. |
ccerv1
requested changes
May 23, 2024
| - address: "0xbf7cb57f08390ef51666ca9e4825c234c6991afa" | ||
| - contract | ||
| name: CrowdFunding | ||
| - address: "0xabF763013d5B2dEfcB7BEaD1342962b24828C7Cf" |
There was a problem hiding this comment.
Almost! The indentation for each address needs to be the same. Sorry - YAML is a finicky format.
The contents look good though :)
|
Closing this out. I've made the updates directly through a separate PR. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.